Re: Don't detect the Python shebang line at build-time; Don't use AM_PATH_PYTHON

[Shigio YAMAGUCHI]

Hello,
I accept your patch. Thank you.

Though the use of AM_PATH_PYTHON was the result of considering
a certain system, I find your solution more reasonable.

However, I expect some people to be affected by this change, so
I'll wait for some objections for two weeks before applying your patch.

Regards,
Shigio

On Thu, Apr 6, 2023 at 10:20 PM Olivier Certner <ocert.dev@free.fr> wrote:
>
> Hello,
>
> - What is your environment (OS)?
> FreeBSD 13
> - Which version of Global are you using?
> 6.6.9
> - What did you do?
> ./configure
> - What did you expect from it?
> Don't try to detect a Python installation at build time and don't pickup the 
> corresponding Python executable to generate the shebang line for the Pygments 
> parser.
> Instead, use a reasonable default line, like "#!/usr/bin/env python", so that 
> resolution happens at run-time.
> Also, I don't expect './configure --help' to present such options: 
> --with-python-sys-prefix, --with-python_prefix, --with-python_exec_prefix. 
> They are relevant only when a Python module is actually installed (which is 
> not the case for Global).
>
> It may however be useful to be able to specify a specific shebang line. 
> Please see the attached patch, which provides '--enable-python-interpreter' 
> to force a Python shebang line (the PYTHON environment variable also works).
>
> If you absolutely want to keep the detection-at-compile-time feature (which I 
> advise against), I can propose another patch so that the "detect" special 
> value for '--enable-python-interpreter' triggers some auto-detection at build 
> time. In any case, AM_PATH_PYTHON must not be used as long as no Python 
> module is installed.
>
> Regards.
>
> --
> Olivier Certner



-- 
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint:
26F6 31B4 3D62 4A92 7E6F  1C33 969C 3BE3 89DD A6EB