bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Enable automatic detection of pread()/pwrite()


From: Shigio YAMAGUCHI
Subject: Re: Enable automatic detection of pread()/pwrite()
Date: Thu, 6 Apr 2023 10:00:26 +0900

Hello,
I accept your patch. Thank you.

By the way, the pread/pwrite configuration was originally auto-detected,
but I had to change to optional because it didn't work properly on Cygwin.
But that judgment may have been wrong. Global does not support Windows
environments, so Cygwin is truncated I'd like to rewrite it like this:

#ifdef HAVE_PREAD
...
#endif
|
v
#if defined(HAVE_PREAD) && !defined(__CYGWIN__)
...
#endif

If requested by Cygwin users, I will remove '!defined(__CYGWIN__)'.
Is this alright?

Regards,
Shigio

On Thu, Apr 6, 2023 at 12:14 AM Olivier Certner <olce.gnu@certner.fr> wrote:
>
> Hello,
>
> - What is your environment (OS)?
> FreeBSD 13
> - Which version of Global are you using?
> 6.6.9
> - What did you do?
> ./configure
> - What did you expect from it?
> Automatically detect that pread() and pwrite() are available.
> - What was occurred?
> Currently, '--with-pread-pwrite' has to be manually specified.
>
> Attached patched makes autoconf automatically probe for pread()/pwrite() (and 
> update 'config.h.in' accordingly).
>
> Regards.
>
> --
> Olivier Certner



-- 
Shigio YAMAGUCHI <shigio@gnu.org>
PGP fingerprint:
26F6 31B4 3D62 4A92 7E6F  1C33 969C 3BE3 89DD A6EB



reply via email to

[Prev in Thread] Current Thread [Next in Thread]