Re: htags fails agaisnt odd filename

[Shigio YAMAGUCHI]

Hi,

I have committed it.

Thank you always!

Regards,

Shigio

2016-02-23 17:32 GMT+09:00 KAICHO <address@hidden>:

Hi,
Thanks for the patch, it works fine in my env.

I'm not sure whether the patch works on Windows OS as well,
it might be better to have further testson Windows.


Anyway, thank you!
KAICHO

----- Original Message -----
>From: Shigio YAMAGUCHI <address@hidden>
>To: KAICHO <address@hidden>
>Cc: "address@hidden" <address@hidden>
>Date: 2016/2/23, Tue 15:18
>Subject: Re: htags fails agaisnt odd filename
>
>
>Hi,
>I have made a patch for it.
>Would you please try this? 
>
>
>Regards,
>Shigio
>
>
>2016-02-23 13:34 GMT+09:00 KAICHO <address@hidden>:
>
>Hi,
>>
>>This is just a small issue and it is easy to avoid by
>>removing/renaming the file which has odd filename.
>>
>>
>>What is your environment (OS)?:
>>CentOS 5.11(Linux x86_64)
>>
>>Which version of GLOBAL are you using?:
>>6.5.2
>>
>>What did you do? (command line)
>># htags
>>
>>What did you expect from it?
>>exit without errors
>>
>>What was occurred? (as is)
>># htags
>>sh: -c: line 0: unexpected EOF while looking for matching `''
>>sh: -c: line 1: syntax error: unexpected end of file
>>htags: command failed in xargs_read().
>>#
>>
>>This is caused by an file which has odd filename, includes
>>'\''(on Unix, probably '"' on Windows). htags fails with
>>the error above on the directory:
>>
>># ls -al
>>total 28
>>drwxr-xr-x  2 root   root    4096 Feb 23 11:47 .
>>drwxr-xr-x 23 apache apache 20480 Feb 23 11:42 ..
>>-rw-r--r--  1 root   root      60 Feb 23 11:43 a'b.c
>>#
>>
>>To fix this, libutil/xargs.c needs to handle the
>>case that QUOTE is in filename, and escape them
>>if necessary.
>>
>>
>>Fortunately, gtags works fine even against these odd
>>filename.
>>
>>Regards,
>>KAICHO
>>
>>
>>_______________________________________________
>>Bug-global mailing list
>>address@hidden
>>https://lists.gnu.org/mailman/listinfo/bug-global
>>
>
>
>
>--
>
>Shigio YAMAGUCHI <address@hidden>
>PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3
>
>
>

--

Shigio YAMAGUCHI <address@hidden>

PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3