Re: gtags-cscope/global finds incorrect callers

[rail shafigulin]

I think it is a right call to change it from  "Find locations calling this function:" to "Find references of this function:". Maybe add a few examples, just like mine above to reduce confusion.

Rail

On Fri, Sep 25, 2015 at 4:45 PM, Shigio YAMAGUCHI <address@hidden> wrote:

> llvm-or1k/in1lude/llvm/CodeGen/MachineScheduler.h|335| <<releaseSucc>> void releaseSucc(SUnit *SU, SDep *SuccEdge);

> llvm-or1k/li1/CodeGen/MachineScheduler.cpp|539| <<releaseSucc>> releaseSucc(SU, &*I);

> llvm-or1k/li1/CodeGen/SelectionDAG/ScheduleDAGVLIW.cpp|86| <<releaseSucc>> void releaseSucc(SUnit *SU, const SDep &D);

> llvm-or1k/lib/CodeGen/SelectionDAG/ScheduleDAGVLIW.cpp|146| <<releaseSucc>> releaseSucc(SU, *I);

>

> Fist and third results are incorrect. They are declarations of these functions and not the callers.

You are right. But they are right by GLOBAL's angle.

The output of ':cs f c releaseSucc' is only the result of 'global -xr releaseSucc'.

The present parser consider declarations which have no definition as references.

So, the fist and third results are not incorrect.

Gtags-cscope is a tool which just borrowed user interface of cscope; it is GLOBAL

itself for the substance.

There is a problem in the title "Find locations calling this function:" on gtags-cscope.

I would like to change it to "Find references of this function:" to reduce misunderstanding.

What do you think?

Regards,

Shigio

--

Shigio YAMAGUCHI <address@hidden>

PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3