Re: [BUG] global abnormally exits when a token contains '@'

[Shigio YAMAGUCHI]

Hi,

I have committed your patch.

Thank you.

Shigio

2014-11-27 0:50 GMT+09:00 Yoshitaro Makise <address@hidden>:

Hi,

I found a bug in the global command.

------------------------------
$ cat sample.sh
echo $@
echo $@
$ GTAGSPYGMENTSOPTS= gtags --gtagslabel=pygments
$ gtags -d GRTAGS
 __.COMPACT     __.COMPACT
 __.COMPLINE     __.COMPLINE
 __.COMPNAME     __.COMPNAME
 __.VERSION     __.VERSION 6
address@hidden   2 @n 1-1
echo    2 @n 1-1
$ global -xs '.*'
address@hidden                 1 sample.sh        echo $@
global: Abbrev character must be a lower alphabetic character. ()
------------------------------

global exits with the message "Abbrev character must be a lower
alphabetic character. ()".

The cause is that in put_compact_format() uncompress() is applied
repeatedly when a tagline has two or more line numbers.
e.g.
  uncompress("@n", "$@");  // 1st iteration
  uncompress("$@", "$@");  // 2nd iteration -> error

The attached patch ensures uncompress() is called only once.

Thanks,

_______________________________________________
Bug-global mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/bug-global

--

Shigio YAMAGUCHI <address@hidden>

PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3