bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Added support for file list in single file update


From: Shigio YAMAGUCHI
Subject: Re: Added support for file list in single file update
Date: Wed, 27 Aug 2014 07:45:38 +0900

2014-08-27 0:59 GMT+09:00 dhruva <address@hidden>:

Generating a list of changes and putting them in 3 separate files is an overhead. Look from a usability perspective, we will have to find all added, deleted and modified files and put them in 3 different files.

In the current approach (my patch), we just put all the 3 types into the same file and it is easy to generate that file. Since I use perforce (p4) SCM at work, I just do "p4 opened|awk "STRIP_SOME_DEPOT_PATH" '{print $2}' | gtags -D -i -f -"

Overall, I would give priority to usability over slight improvement in performance. Doing it in batch mode gives use sufficient performance boost with no impact on usability.

 
OK. But there is no necessity of withdrawing the optimization.
How about adding the 4th '--update' option?

--update-add: added files
--update-delete: deleted files
--update-change: changed files
--update: added/deleted/changed files

I believe '--update' == '-D -i -f'
The following two are almost the same.

$ gtags --update-add=added --update-delete=deleted --update-change=changed
$ cat added deleted changed | gtags --update=-

Shigio

--
Shigio YAMAGUCHI <address@hidden>
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3

reply via email to

[Prev in Thread] Current Thread [Next in Thread]