bug-global
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Allow specifying both of -r and -s for -f on 2-pass mode


From: Hideki IWAMOTO
Subject: Re: [PATCH] Allow specifying both of -r and -s for -f on 2-pass mode
Date: Sun, 22 Nov 2009 17:57:36 +0900

Hi.

> By the way, how about separating between the tag type and name
> by single blank?
> And if possible, would you please write a simple comment about
> the change in ChangeLog.

OK. This is revised version.
I will commit this patch on the next weekend. 

 ChangeLog             |   10 +++++
 global/global.c       |   87 +++++++++++++++++++++++++++++---------------------
 gtags/gtags.c         |    2 -
 htags/anchor.c        |   52 +++++++++++++++++------------
 htags/anchor.h        |    8 ++--
 htags/htags.c         |    3 +
 htags/htags.h         |    1
 libutil/format.h      |   29 ++++++++++------
 libutil/pathconvert.c |   18 +++++++++-
 libutil/pathconvert.h |    7 +---
 10 files changed, 139 insertions(+), 78 deletions(-)

On Sun, 22 Nov 2009 10:24:44 +0900, Shigio YAMAGUCHI wrote...
> Hi
> > The number of executions of "global -f" from htags has decreased
> > by this change and adding new format to --result option. 
> > The CPU time of 2-pass mode is shorter than that of the default mode now. 
> 
> Good job.  The speed decrease of htags was completely canceled,
> and it has been improved further.
> 
> By the way, how about separating between the tag type and name
> by single blank?
> 
> Dmain              219 global/global.c  main(int argc, char **argv)
> |
> v
> D main              219 global/global.c  main(int argc, char **argv)
> 
> Limiting tag type to single character will become a limitation
> for some enhancing in the future.
> 
> And if possible, would you please write a simple comment about
> the change in ChangeLog.
> Thank you.
> --
> Shigio YAMAGUCHI <address@hidden>
> PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3

----
Hideki IWAMOTO  address@hidden

Attachment: 20091122-global-frs+ctags-xtype.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]