Re: [PATCH] seems_datatype in gctags

[Shigio Yamaguchi]

Fixed by modified patch like follows.
This patch is logically equal to your patch, I think.

Thank you.

Index: C.c
===================================================================
RCS file: /cvsroot/global/global/gctags/C.c,v
retrieving revision 1.28
diff -c -r1.28 C.c
*** C.c 19 Mar 2003 09:17:59 -0000      1.28
--- C.c 19 Mar 2003 11:04:40 -0000
***************
*** 477,486 ****
                /* pick up symbol */
                if (c == SYMBOL) {
                        if (target == REF) {
!                               if (seems_datatype(token))
                                        PUT(token, lineno, sp);
!                       } else if (target == SYM)
!                               PUT(token, lineno, sp);
                }
        }
        if (c == EOF)
--- 477,488 ----
                /* pick up symbol */
                if (c == SYMBOL) {
                        if (target == REF) {
!                               if (seems_datatype(token) && defined(token))
                                        PUT(token, lineno, sp);
!                       } else if (target == SYM) {
!                               if (!seems_datatype(token) || !defined(token))
!                                       PUT(token, lineno, sp);
!                       }
                }
        }
        if (c == EOF)
Index: Cpp.c
===================================================================
RCS file: /cvsroot/global/global/gctags/Cpp.c,v
retrieving revision 1.25
diff -c -r1.25 Cpp.c
*** Cpp.c       19 Mar 2003 09:17:59 -0000      1.25
--- Cpp.c       19 Mar 2003 11:04:40 -0000
***************
*** 518,527 ****
                /* pick up symbol */
                if (c == SYMBOL) {
                        if (target == REF) {
!                               if (seems_datatype(token))
                                        PUT(token, lineno, sp);
!                       } else if (target == SYM)
!                               PUT(token, lineno, sp);
                }
        }
        if (c == EOF)
--- 518,529 ----
                /* pick up symbol */
                if (c == SYMBOL) {
                        if (target == REF) {
!                               if (seems_datatype(token) && defined(token))
                                        PUT(token, lineno, sp);
!                       } else if (target == SYM) {
!                               if (!seems_datatype(token) || !defined(token))
!                                       PUT(token, lineno, sp);
!                       }
                }
        }
        if (c == EOF)
Thank you.

> This is multipart message.
> 
> ----------------------0192065987268395
> Content-Type: text/plain; charset=us-ascii
> 
> typedef name whose length is 1 or 2 is used heavily on embedded systems based
 on TRON.
> So, it is not good to recognize typedef by the length of the name.
> 
> attached is updated version.
> 
>   * C.c (function_definition): Changed so that a symbol might not be register
ed into both GRTAGS and GSYMS. 
>          Changed so that the symbol which is not registered into GTAGS might 
not be registered into GRTAGS.
>   * Cpp.c (function_definition): Likewise.
>   * C.c (seems_datatype): Corrected the treatment of the return value of strc
mp.
>          Removed judgment by the length of a name.
>   * Cpp.c (seems_datatype): Likewise.
> 
> On Wed, 12 Mar 2003 19:34:54 +0900, Hideki IWAMOTO wrote...
> >  * C.c (function_definition): Changed so that a symbol might not be registe
red into both GRTAGS and GSYMS. 
> >         Changed so that the symbol which is not registered into GTAGS might
 not be registered into GRTAGS.
> >  * Cpp.c (function_definition): Likewise.
> >  * C.c (seems_datatype): Corrected the treatment of the return value of str
cmp.
> >  * Cpp.c (seems_datatype): Likewise.
> >  
> 
> ----
> Hideki IWAMOTO  address@hidden
--
Shigio Yamaguchi <address@hidden> - Tama Communications Corporation
PGP fingerprint: D1CB 0B89 B346 4AB6 5663  C4B6 3CA5 BBB3 57BE DDA3