Re: gawk and gen-insn-attr-x86.awk

[Jeff Chua]

Arnold,

Thanks for fixing this. The latest git-pull fixed the issue.

This was a tricky one. I guess not many would hit this one. And it only
happens on a fresh linux build. Incremental build would not call the awk
script.

Thank you!

My best.,
Jeff


On Fri, Sep 23, 2022 at 4:30 PM <arnold@skeeve.com> wrote:

> [ Redirecting to the bug list. ]
>
> Hi Jeff.
>
> Thanks for the report and for sending me the files (privately).
> The patch, relative to the released gawk-5.2.0 tarball, is attached.
> I'm hoping that this is the final fix for bugs in this bit of code.
>
> Andreas --- Please replace the previous fix I sent you with this one.
>
> I will be pushing the change and test case to Git shortly.
>
> I am waiting for the rate of incoming bug reports to settle down
> and then I'll make a patch release.
>
> Thanks!
>
> Arnold
>
> Jeff Chua <jeff.chua.linux@gmail.com> wrote:
>
> > Masami-san and Arnold,
> >
> > The recent git pull gawk (after July 5) is break linux kernel tools
> > /usr/src/linux/linux/tools/arch/x86/tools/gen-insn-attr-x86.awk
> >
> > I don't know who should fix this ..
> >
> > Try this ..
> >
> > # /usr/bin/awk -f ./arch/x86/tools/gen-insn-attr-x86.awk
> > ./arch/x86/lib/x86-opcode-map.txt >objtool/arch/x86/lib/inat-tables.c.ok
> >
> > # /usr/test/git/gawk/gawk -f ./arch/x86/tools/gen-insn-attr-x86.awk
> > ./arch/x86/lib/x86-opcode-map.txt >objtool/arch/x86/lib/inat-tables.c.bad
> >
> > # diff inat-tables.c.ok inat-tables.c.bad
> > 6,17c6,17
> > <       [0x00] =  | INAT_MODRM,
> > <       [0x01] =  | INAT_MODRM,
> > <       [0x02] =  | INAT_MODRM,
> > <       [0x03] =  | INAT_MODRM,
> > <       [0x04] =  | INAT_MAKE_IMM(INAT_IMM_BYTE),
> > <       [0x05] =  | INAT_MAKE_IMM(INAT_IMM_VWORD32),
> > <       [0x08] =  | INAT_MODRM,
> > <       [0x09] =  | INAT_MODRM,
> > <       [0x0a] =  | INAT_MODRM,
> > <       [0x0b] =  | INAT_MODRM,
> > <       [0x0c] =  | INAT_MAKE_IMM(INAT_IMM_BYTE),
> > <       [0x0d] =  | INAT_MAKE_IMM(INAT_IMM_VWORD32),
> > ---
> > >       [0x00] = INAT_MODRM,
> > >       [0x01] = INAT_MODRM,
> > >       [0x02] = INAT_MODRM,
> > >       [0x03] = INAT_MODRM,
> > >       [0x04] = INAT_MAKE_IMM(INAT_IMM_BYTE),
> > >       [0x05] = INAT_MAKE_IMM(INAT_IMM_VWORD32),
> > >       [0x08] = INAT_MODRM,
> > >       [0x09] = INAT_MODRM,
> > >       [0x0a] = INAT_MODRM,
> > >       [0x0b] = INAT_MODRM,
> > >       [0x0c] = INAT_MAKE_IMM(INAT_IMM_BYTE),
> > >       [0x0d] = INAT_MAKE_IMM(INAT_IMM_VWORD32),
> >
> >
> >
> > My best.,
> > Jeff
>