Re: [PATCH] Add missing UPREF.

[Emanuel Attila Czirai]

On Wed, Sep 14, 2022 at 9:37 PM <arnold@skeeve.com> wrote:
>
> Hello.
>
> Although the suggested patch fixed the bug, and I even committed
> it to git, it did not solve the problem, as seen from a later
> bug report.

Ah, I see what you mean:
https://lists.gnu.org/archive/html/bug-gawk/2022-09/msg00057.html

> I reverted it (but not the test cases) and have used
> the patch attached in this email.  I will push to the Savannah repo
> shortly.

Got it: 
https://git.savannah.gnu.org/cgit/gawk.git/commit/?id=2848045aed5ccfd7b582808288f7fcc18d319952

>
> Thanks again for the report.

I can confirm that the attached patch makes both errors go away!
Thank you! Much appreciated!

>
> Arnold
>
> Emanuel Attila Czirai <corre.a.buscar@gmail.com> wrote:
>
> > I can confirm that the crash goes away with that patch.
> > Thank you so much!
> >
> > On Mon, Sep 5, 2022 at 5:49 PM Jan Alexander Steffens (heftig)
> > <heftig@archlinux.org> wrote:
> > >
> > > Fixes: d2e694ad66a379fa128137d19c10b77b942972f2
> > > Fixes: https://bugs.gentoo.org/868567
> > > Fixes: https://lists.gnu.org/archive/html/bug-gawk/2022-09/msg00006.html
> > > ---
> > >  interpret.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/interpret.h b/interpret.h
> > > index 57d060e63f37..268655b2231f 100644
> > > --- a/interpret.h
> > > +++ b/interpret.h
> > > @@ -238,6 +238,7 @@ uninitialized_scalar:
> > >                                                 _("reference to 
> > > uninitialized argument `%s'") :
> > >                                                 _("reference to 
> > > uninitialized variable `%s'"),
> > >                                                                 
> > > save_symbol->vname);
> > > +                               UPREF(m);
> > >                                 PUSH(m);
> > >                                 break;
> > >