Re: Report 4 different bugs discoverd in gawk

[Paul Eggert]

On 8/2/22 10:01, arnold@skeeve.com wrote:

> Sure Paul, if you have suggestions I'd be happy to review them.

I took a look at that and came up with the attached patches, which 
address a few of the problems. Several more patches are needed 
(particularly with the MPFR stuff, I expect) but you gotta start 
somewhere and I figured I'd pass these along and see whether it's 
heading in the right direction for you.

The first patch is merely to pacify GCC 12 and slightly improve the 
quality of the code that GCC generates. It can be omitted if you don't 
mind the bogus warnings or the slightly-slower code.

The second patch syncs the Gnulib integer overflow code to equal the 
current Gnulib version. This is mostly to make the code safe for C23. 
You can omit this if you don't care about C23.

The third patch is what does the work. It's mostly in the sprintf area, 
as that was what caught my eye first (it's surely not the most important 
of the bugs, but one thing at a time....).

I have written some more code along these lines but have not tested or 
checked it yet.

0001-Use-_Noreturn-a-bit-more.patch
Description: Text Data

0002-Update-support-files-from-GNULIB.patch
Description: Text Data

0003-Improve-integer-overflow-checking-for-formats.patch
Description: Text Data