Re: [bug-gawk] About AWKLIBPATH

[arnold]

Andy,

OK to push that. Please pull first.

Thanks,

Arnold

"Andrew J. Schorr" <address@hidden> wrote:

> On Wed, Feb 07, 2018 at 01:48:26PM -0500, Andrew J. Schorr wrote:
> > But oy, I just built and installed gawk-4.2-stable, and you are right:
> > the extensions are now going in PREFIX/lib/gawk-extensions.
> > This is broken. It does not match the AWKLIBPATH compiled into gawk.
>
> I think the problem is in this change to extension/configure.ac from
> gawk-4.1-stable to gawk-4.2-stable:
>
> -AC_SUBST([pkgextensiondir], ['${libdir}/gawk'])
> +dnl use the same definition as the main configure script.
> +dnl EXTENSIONDIR is exported if it was set there.
> +AC_SUBST([pkgextensiondir], ['${pkglibdir}'${EXTENSIONDIR}])
>
> The problem is that $pkglibdir is set to $prefix/lib/gawk-extensions, which
> doesn't match what we want. I think the fix is simply to use the previous
> value with ${EXTENSIONDIR} tacked on:
>
> diff --git a/extension/configure.ac b/extension/configure.ac
> index e8b242a..2b91336 100644
> --- a/extension/configure.ac
> +++ b/extension/configure.ac
> @@ -56,7 +56,9 @@ dnl AC_PROG_INSTALL
>  
>  dnl use the same definition as the main configure script.
>  dnl EXTENSIONDIR is exported if it was set there.
> -AC_SUBST([pkgextensiondir], ['${pkglibdir}'${EXTENSIONDIR}])
> +dnl N.B. We must use ${libdir}/gawk instead of $pkglibdir because $pkglibdir
> +dnl is set to ${libdir}/gawk-extensions, which is not what we want.
> +AC_SUBST([pkgextensiondir], ['${libdir}/gawk'${EXTENSIONDIR}])
>  
>  if test "$GCC" = yes
>  then
>
> Arnold -- OK to commit this?
>
> Regards,
> Andy