bug-findutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix compilation warning.


From: Dmitry V. Levin
Subject: [PATCH] Fix compilation warning.
Date: Mon, 28 Dec 2015 19:54:43 +0300

xargs.c: In function 'fopen_cloexec_for_read_only':
xargs.c:387:1: warning: control reaches end of non-void function [-Wreturn-type]
* xargs/xargs.c (fopen_cloexec_for_read_only): Return result.
---
 xargs/xargs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xargs/xargs.c b/xargs/xargs.c
index 86e0479..1116cfe 100644
--- a/xargs/xargs.c
+++ b/xargs/xargs.c
@@ -369,21 +369,22 @@ smaller_of (size_t a, size_t b)
 static FILE* fopen_cloexec_for_read_only (const char *file_name)
 {
   int fd = open_cloexec (file_name, O_RDONLY);
   if (fd < 0)
     {
       return NULL;
     }
   else
     {
       FILE *result = fdopen (fd, "r");
       if (!result)
        {
          int saved_errno = errno;
          close (fd);
          errno = saved_errno;
          return NULL;
        }
+      return result;
     }
 }
 
 
-- 
ldv



reply via email to

[Prev in Thread] Current Thread [Next in Thread]