findutils still uses Automake's AM_C_PROTOTYPES macro, but that's going to be removed

[Stefano Lattarini]

Hello findutils developers.

I see that findutils currently still uses the Automake's AM_C_PROTOTYPES
macro in its `configure.ac'.  I want to inform you that that macro (along
with all the rest of the ansi2knr machinery) will be deprecated in the
next minor Automake release (1.11.2), and will be removed altogether in
the next major Automake release (1.12).  I think this is an acceptable
move, since we should have finally reached the point when one doesn't
have to worry about non-ANSI C compilers anymore (I mean, C compilers
that understands only K&R C, and not C89).

See this thread on automake's list for more details:
 <http://lists.gnu.org/archive/html/automake/2011-06/msg00007.html>

Attached is a small patch that removes the use of AM_C_PROTOTYPES from
the findutils tree.  After it, bootstrap, configuration, build and
testsuite still pass (on my Debian GNU/Linux system).

Regards,
  Stefano

From 7012ed3bfe31c79dfe4eacc2928fec08888971aa Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Mon, 10 Oct 2011 19:30:22 +0200
Subject: [PATCH] Remove vestigial de-ANSI-fication support.

The support for automatic de-ANSI-fication has been deprecated in
automake 1.11.2, and will be removed altogether in automake 1.12.
Also, findutils hasn't been using the `ansi2knr' option since at
least commit 01479665859eac23d4bb02b9926370537c059eff, dating back
to 2004-11-21.

* configure.ac (AM_C_PROTOTYPES): Remove call to this macro.
Remove other ansi2knr-related cruft (already commented-out).
---
 ChangeLog    |   11 +++++++++++
 configure.ac |    6 ------
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8f55258..c137259 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2011-10-10  Stefano Lattarini <address@hidden> (tiny change)
+
+       Remove vestigial de-ANSI-fication support.
+       The support for automatic de-ANSI-fication has been deprecated in
+       automake 1.11.2, and will be removed altogether in automake 1.12.
+       Also, findutils hasn't been using the `ansi2knr' option since at
+       least commit 01479665859eac23d4bb02b9926370537c059eff, dating back
+       to 2004-11-21.
+       * configure.ac (AM_C_PROTOTYPES): Remove call to this macro.
+       Remove other ansi2knr-related cruft (already commented-out).
+
 2011-09-11  Jim Meyering  <address@hidden>
 
        Fix a typo in find.texi.
diff --git a/configure.ac b/configure.ac
index 5ed3e91..6d31c43 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,8 +77,6 @@ AC_PROG_CPP
 dnl for gnulib
 gl_EARLY
 
-AM_C_PROTOTYPES
-
 AC_PROG_INSTALL
 AC_PROG_RANLIB
 dnl AC_PROG_LIBTOOL
@@ -231,10 +229,6 @@ dnl Hence they need to know if they are being compiled 
into findutils or not.
 AC_DEFINE([FINDUTILS], 1, [Define if we are compiling GNU findutils])
 AC_DEFINE([ALREADY_INCLUDED_CONFIG_H], 1, [Define so that source code can 
verify that config.h was already included])
 
-# This is necessary so that .o files in LIBOBJS are also built via
-# the ANSI2KNR-filtering rules.
-#LIBOBJS=`echo $LIBOBJS|sed 's/\.o /\$U.o /g;s/\.o$/\$U.o/'`
-
 # Note that in the list below, po/Makefile.in should appear before
 # po/Makefile, so that po/Makefile can be created even if po/Makefile.in
 # starts off missing.
-- 
1.7.2.3