bug-findutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: findutils POSIX incompatiblity with "find . -perm ++w -print"


From: Paul Eggert
Subject: Re: findutils POSIX incompatiblity with "find . -perm ++w -print"
Date: Tue, 24 May 2005 09:37:46 -0700
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux)

I did notice one minor inefficiency in the patch
<http://lists.gnu.org/archive/html/bug-findutils/2005-05/msg00426.html>.
that I submitted yesterday.  This code:

   if (argv[*arg_ptr][0] == '+' && (change = mode_compile (argv[*arg_ptr])))
     ...

can be replaced by:

   change = mode_compile (argv[*arg_ptr]);
   if (change)
     ...

since argv[*arg_ptr][0] is already known to be '+' at that point.
Sorry about the infelicity.  If you like, I can compose a new proposed
patch reflecting this change.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]