Re: [Patch] locate --non-existing (-E): New option.

[Bas van Gompel]

Op Mon, 18 Apr 2005 10:05:02 +0100 schreef James Youngman
in <address@hidden>:
:  On Mon, Apr 18, 2005 at 04:44:50AM +0200, Bas van Gompel wrote:
[patch which implements a ``--non-existing'' (``-E'') option]

:  I've applied your patch.  Mnay thanks for your contribution.

You're welcome.

:   I did
:  change a few things though :-

Of course, as should be. :]

:  1. Arguments to Texinfo commands are enclosed in {} not (), and so a change 
:     to find.texi was required in order for "make" to succeed.

Oops! I should have spotted that. Mea culpa.

:  2. I added test suite tests for the -E option (and the -e option).

That's nice. I really should look at that testsuite sometime...

:  3. I changed the type of check_existence from into to enum

Much more readable.

:  and added
:      some comments to locate.c.

Here's some little fixes for those.

[...]

(There were also some formatting-changes and something about a
``between-hook'' in your patch...)



diff --exclude='*~' -Ndrup curr/findutils/locate/locate.c 
mine2/findutils/locate/locate.c
--- findutils/locate/locate.c   2005-04-18 21:54:44.000000000 +0200
+++ findutils/locate/locate.c   2005-04-19 20:43:02.000000000 +0200
@@ -361,7 +361,7 @@ visit_existing_follow(const char *munged
     }
 }
 
-/* visit_existing_follow implements -L -E */
+/* visit_non_existing_follow implements -L -E */
 static int
 visit_non_existing_follow(const char *munged_filename,
                          const char *original_filename,
@@ -411,7 +411,7 @@ visit_existing_nofollow(const char *mung
     }
 }
 
-/* visit_existing_nofollow implements -P -E */
+/* visit_non_existing_nofollow implements -P -E */
 static int
 visit_non_existing_nofollow(const char *munged_filename,
                            const char *original_filename,


L8r,

Buzz.
-- 
  ) |  | ---/ ---/  Yes, this | This message consists of true | I do not
--  |  |   /    /   really is |   and false bits entirely.    | mail for
  ) |  |  /    /    a 72 by 4 +-------------------------------+ any1 but
--  \--| /--- /---  .sigfile. |   |perl -pe "s.u(z)\1.as."    | me. 4^re