Re: GNU Fileutils - chauthor.

[Niels Möller]

address@hidden (Alfred M. Szmidt) writes:

> And here I go again.  This time it's a whole new program, that will
> allow you to change the st_author field on GNU/Hurd.

Just one comment, on the Makefile:

> --- fileutils-4.1.7.orig/src/Makefile.am      Sun Feb 17 12:00:25 2002
> +++ fileutils-4.1.7-chauthor/src/Makefile.am  Sun Apr  7 10:03:35 2002
> @@ -3,9 +3,15 @@ AUTOMAKE_OPTIONS = ansi2knr
>  
>  EXTRA_PROGRAMS = df
>  
> +if HURD
> +CHAUTHOR = chauthor
> +else
> +CHAUTHOR =
> +endif
> +
>  bin_PROGRAMS = chgrp chown chmod cp dd dircolors du \
>  ginstall ln dir vdir ls mkdir \
> -mkfifo mknod mv rm rmdir shred sync touch @DF_PROG@
> +mkfifo mknod mv rm rmdir shred sync touch $(CHAUTHOR) @DF_PROG@

You should probably change this to be more similar to the handling of
DF_PROG. I.e. use

  EXTRA_PROGRAMS = df chauthor

and

  mkfifo mknod mv rm rmdir shred sync touch @CHAUTHOR_PROG@ @DF_PROG@

in the bin_PROGRAMS list. Then have configure.in use AC_SUBST to set
CHAUTHOR_PROG to a suitable value, based on the existence of the
author field in struct stat or something like that (iirc, you already
have configure tests for that).

Regards,
/Niels