Re: [Bug-ddrescue] [PATCH 3/5] io: Add missing prototype

[Rosen Penev]

On Mon, Aug 5, 2019 at 9:51 AM Antonio Diaz Diaz <address@hidden> wrote:
>
> Rosen Penev wrote:
> > Found with -Wmissing-prototypes
> > --- a/io.cc
> > +++ b/io.cc
> > @@ -34,6 +34,7 @@ namespace {
> >
> >   int volatile signum_ = 0;           // user pressed Ctrl-C or similar
> >
> > +extern "C" void sighandler( int signum );
> >   extern "C" void sighandler( int signum )
> >     { if( signum_ == 0&&  signum>  0 ) signum_ = signum; }
>
> There is nothing missing here. A function definition is a function
> declaration in which the body of the function is presented. Therefore
> there is no need to declare the function twice.
My understanding here is that this function needs to be static or
declared separately. static cannot be used with extern so I went for
the other option.
>
> I would report this unneeded addition of a prototype as a bug to the
> compiler developers.