Re: [Bug-ddrescue] Cannot compile with uClibc-ng

[Antonio Diaz Diaz]

Rosen Penev wrote:
> > > > IMO this is a bug in uClibc-ng
> > > Even so, it might still make sense to work around it.
> >
> > I don't see how this can be done. Using plain 'fgetc' instead of
> > 'std::fgetc' will fail with conforming libc implementations.
> I don't really do C++, but this is one of the ways a similar issue was
> fixed:
> https://github.com/facebook/folly/commit/b2cecfb5ced32cac372cfe6c5ac1935365b5dd60

That fix is for std::remainder, which is C++11 and therefore not present 
in previous versions of the standard. I made a similar fix for 
std::snprintf, which was introduced in C99 and was therefore absent from 
C++98.

The case of std::fgetc is different. 'fgetc' is in C since the dawn of 
time and therefore std::fgetc must be provided by any compliant C++ 
library. IMO this bug should not be worked around, but fixed in uClibc-ng.

Best regards,
Antonio.