bug-ddrescue
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-ddrescue] [PATCH] ascii "vissualization"


From: Ariel
Subject: Re: [Bug-ddrescue] [PATCH] ascii "vissualization"
Date: Mon, 14 Aug 2006 22:24:13 -0400 (EDT)


On Tue, 15 Aug 2006, Michael Niedermayer wrote:

attached you will find a patch which adds some ascii vissualization of the
ddrescuing, if your terminal supports it should be colorized too

This is interesting, but I don't think hard coding ANSI escape sequences is such a good idea. You don't know what terminal people will be using.

Also you should use ioctl TIOCGWINSZ and sigwinch to detect the terminal size rather then have people type it in themself.

However, that too, may cause portability problems.

I would maybe recommend investigating curses, and using that. It should be fully portable, although the full curses library seems somewhat overkill for this purpose.

I don't have other advice/ideas, maybe the programmer of ddrescue will have some.

        -Ariel




reply via email to

[Prev in Thread] Current Thread [Next in Thread]