Re: Error when compiling code on armv7hl

[Erik Auerswald]

Thanks!

On 14.05.22 13:30, Shawn Wagner wrote:
> Went with the PRIdMAX version. Thanks!
>
> On Fri, Jan 7, 2022 at 8:15 PM Erik Auerswald
> <auerswal@unix-ag.uni-kl.de> wrote:
> > Hello Jiri,
> >
> > On 07.01.22 12:37, Jiri Hladky wrote:
> > > Hello Assaf,
> >
> > I'm not Assaf, but I'll try to help anyway.
> >
> > > I'm a datamash package maintainer for Fedora. I have tried to compile
> > > version 1.7, but I'm getting an error when compiling decorate.c for armv7hl
> > > architectures (all other arches compile just fine).
> > >
> > > Could you please have a look? It seems to be an integer type mismatch.
> >
> > The problem seems to be that the "%zu" format specifier is used,
> > but that is specific to "size_t".  I would expect that "size_t"
> > often is practically identical to "intmax_t", so this often works.
> >   From the error message I would assume that on armv7hl
> > sizeof(size_t) != sizeof(intmax_t).
> >
> > It seems to me as if line src/decorate.c:445 should use either
> > "%jd" or "%"PRIdMAX instead of "%zu".
> >
> > Since PRIuMAX is already used in datamash, use of PRIdMAX may be
> > preferable.
> >
> > The two attached patches against git HEAD work on my x86-64
> > GNU/Linux system, perhaps they work for your Fedora builds, too?
> >
> > You only need one or the other patch, not both, depending if you
> > prefer "%jd" or "%"PRIdMAX.
> >
> > HTH,
> > Erik