[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug #18530] Sparc SIGBUS in md5 routines
|
From: |
Ingolf Steinbach |
|
Subject: |
Re: [bug #18530] Sparc SIGBUS in md5 routines |
|
Date: |
Wed, 20 Dec 2006 14:11:14 +0100 |
|
User-agent: |
Thunderbird 1.5.0.9 (Windows/20061207) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi.
Mark D. Baushke schrieb:
> RCS file: /cvsroot/cvs/ccvs/src/cvs.h,v
[...]
> +typedef union {
> + uint32_t int_checksum[4];
> + unsigned char char_checksum[16];
> +} checksum_t;
<nit_pick>
Wouldn't it be more consistent to use
uint8_t byte_checksum[16];
here rather than relying on char being 8-bit?
</nit_pick>
(But I understand that platforms with non-8-bit chars might not
be supported anyway.)
Cheers
Ingolf
- --
Ingolf Steinbach PGP:0x040DD527 Jena-Optronik GmbH
ingolf.steinbach@jena-optronik.de ++49 3641 200-216
Fingerprint: 33BE B2C6 5F42 5C24 4091 F0AD 3EE8 1082 040D D527
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFFiTZyPugQggQN1ScRApjUAKC9q3XoWnLnUZ1Mv0U/xw6ryldeGgCcCypz
wPZq5sKlyXb7W2rBXvBiknw=
=Ol+E
-----END PGP SIGNATURE-----