Re: Feature Branch Windows Build Broken - New GNULIB glob module

[Derek Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Conrad T. Pino wrote:

>I saw you're involved with Paul Eggert on a "New GNULIB module" topic
>and assumed we had done another GNULib import which has often broken
>the Windows build.


Well, basically.  I created the glob module myself and added it to CVS
and Paul has been reviewing it and I've been correcting it in ways to
make it compatible with GNULIB & GLIBC.

>I have my nose buried in another project. My patch is a blind guess
>since I didn't look at the UNIX build to see what is going on there.
>Your comments lead me to believe I made a lucky guess using "glob_.h"
>and compiling "glob.c" in the "libcvs" build.


I can't comment on how lucky you were, but you did arrive at the correct
solution.  :)

>I'm willing to commit the Windows build and "windows-NT/pwd.?" files.
>What's your preference on who sends "glob_.h" patch to GNULib team?


I'll do it.  It should slide into my ongoing discussion with Paul about
this new module easily enough.

>+#ifndef __restrict
>+# define __restrict
>+#endif


This is not correct.  It should be

#ifndef __restrict
# define __restrict restrict
#endif

If the "restrict" keyword is not supported by MSVC, then in
windows-NT/config.h.in.in, "restrict" should be defined to some
variation of "__restrict", "__restrict__", "_Restrict", or empty.

The rest of your patch looks fine.

Regards,

Derek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCijCdLD1OTBfyMaQRAiT0AJ9Ddc7GePXgTuDhFl4WwVBRLebLfQCfViZR
Z5bC5MkdHep6RyAa8dR9dxE=
=c50w
-----END PGP SIGNATURE-----