Re: rdiff

[Derek Robert Price]

Paul Edwards wrote:

> "Derek Robert Price" <derek@ximbiot.com> wrote in message 
> news:mailman.7283.1054740779.21513.bug-cvs@gnu.org...
>  
>
> > @@ -596,6 +591,18 @@
> >             * lines of the diff output file, and munge them to include more
> >             * reasonable file names that "patch" will understand.
> >             */
> > +           if( patch_short )
> >    
>
> I would have included this block before the comment line, as
> the comment doesn't apply to it.

I extended the comment line with an "unless the user wanted a short 
patch.  In that case..." instead since I likes the comment at the start 
of the "case 1" - it explains the work of the "case 1" pretty well.

> > +           {
> > +               cvs_output( "File ", 0 );
> > +               cvs_output( finfo->fullname, 0 );
> > +               cvs_output( " changed from revision ", 0 );
> > +               cvs_output( vers_tag, 0 );
> > +               cvs_output( " to ", 0 );
> > +               cvs_output( vers_head, 0 );
> > +               cvs_output( "\n", 1 );
> > +               ret = 0;
> > +               goto out2;
> >    
>
> And this should be out, not out2, in order to get the right
> cleanup, I believe.  The wonderful world of gotos - clear
> as mud.

Yep.  Thanks.

> > The sanity.sh tests pass with this patch, but your cases do not appear
> > to be tested.  Could you write some sanity.sh test cases for an added
> > file, a removed file, a file with no differences between releases, and a
> > file which exists but was not in either release, so that I may commit
> > this?  It would probably be simplest to just add a new test set,
> > rdiff-add-remove-nodiff or the like.
> >    
>
> I'll see if I can do this.
>  

Thanks again.

Derek

--
               *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
--
Since English is a mess, it maps well onto the problem space,
which is also a mess, which we call reality.

        - Larry Wall