Re: Allowing regular expression in --allow-root option

[Christian BAYLE]

Hi Derek

Derek R Price wrote

> I'm not sure how generally useful this is, but I also can't really see it as
> a
> bad thing.

We need this in the packaging of sourceforge for debian distro
For the moment we use a wrapper, that can be quite heavy with a lot of
projects.

> 
> I don't like this fix though, for a number of reasons:
> 
> 1)  You haven't attached a ChangeLog entry, doc/cvs.texinfo documentation
> changes, or src/sanity.sh test cases.  See the HACKING file in the top level
> of the CVS source distribution for more.
It's done

> 
> 2)  I don't want the old behavior of the --alow-root option changed.  Add a
> --allow-root-regexp option.
> 
It's done like this

> 3)  If we're going to go this far, full regexps should be allowed.  The
> argument to --allow-root-regexp should be matched against the entire path.
> 
It's done like this

> If you want to go ahead with this, create an issue on ccvs.cvshome.org with
> this information, including the above design considerations and any comments
> you may like to add, then create the new patch and attach it to the issue.

The issue is no on the ccvs site as number #41
the patch was mostly done by Roland Mas <lolando@debian.org> 
(the debian-sf packager) and tested by me.

It's there http://ccvs.cvshome.org/issues/show_bug.cgi?id=41
Nothing was done in sanity.sh
I couldn't see testing portion with several --allow-root
and didn't understand yet how this test works.

Christian Bayle