[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62404: --reflink=auto not falling back appropriately on older kernel
From: |
Pádraig Brady |
Subject: |
bug#62404: --reflink=auto not falling back appropriately on older kernels |
Date: |
Thu, 23 Mar 2023 14:55:06 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 |
On 23/03/2023 13:39, Pádraig Brady wrote:
On 23/03/2023 13:03, Pádraig Brady wrote:
Details at
https://github.com/termux/termux-packages/issues/15706#issuecomment-1481144831
But in summary, the new --reflink errno checking in coreutils 9.2
is not working appropriately on android 4.9 kernels at least.
Proposed patch attached.
It may be better to key on kernel version rather than __ANDROID__
(along the lines of https://github.com/coreutils/coreutils/commit/ba5e6885d),
but that needs more investigation.
Actually it seems the errno checking may be too brittle in general,
https://www.reddit.com/r/Proxmox/comments/11zieha/cpmvinstall_are_broken_in_unprivileged_containers/
Perhaps we should use the above __ANDROID__ logic in all cases,
so that we fallback unless there is a specific reason not to.
The attached does that.
cheers,
Pádraig
copy-clone-fallback.patch
Description: Text Data