bug#50972: src/ls.c fails to build when __GNUC_PREREQ is not defined (e.g., OpenBSD)

[Brian Callahan]

Hi Paul --

On 10/02/2021 10:07 PM, Paul Eggert wrote:
> The first patch listed above should fix the problem you mentioned; you
> might want to look at the other patches as well.

Much appreciated. Can confirm the tip of the tree builds OOTB now.

> By the way, how do you deal with all those false positives from clang?
> Do you suppress them with CFLAGS? I'm referring to the many warnings
> like "comparison is always true due to limited range of data type" and
> a few "integer overflow in expression" warnings. With so many false
> alarms I wouldn't be surprised if people stopped paying attention to
> compiler warnings even if they're valid.

OpenBSD 7.0 (which is ready to go, just hasn't had an official 
announcement) ships with clang 11.1.0, whereas OpenBSD 6.9 ships with 
clang 10.0.1. I did not try to build coreutils-9.0 on 6.9 but on 7.0 
there are virtually no warnings during the build (even before these 
fixes).

I can send you a build log offlist if you'd like to see what the 7.0 
build looks like.

~Brian