bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#50611: one-byte (write) heap-buffer-underrun


From: Pádraig Brady
Subject: bug#50611: one-byte (write) heap-buffer-underrun
Date: Thu, 16 Sep 2021 20:43:00 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0

On 16/09/2021 19:51, Paul Eggert wrote:
On 9/16/21 4:34 AM, Pádraig Brady wrote:
It got me thinking though, that we should not we warning/failing on
blank lines.
I.e., we should be treating blank lines like comments.
The attached does that.

Thaks, a good improvement. The nerd in me also suggests changing this:

        line[line_length] = '\0';

        /* Ignore blank lines.  */
        if (line_length == 0)
          continue;

to this:

        /* Ignore empty lines.  */
        if (line_length == 0)
          continue;

        line[line_length] = '\0';

Pushed with that adjustment.

cheers,
Pádraig





reply via email to

[Prev in Thread] Current Thread [Next in Thread]