[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#44235: [PATCH] dd: drop old workaround for lseek() bug in Linux kern
|
From: |
Kamil Dudka |
|
Subject: |
bug#44235: [PATCH] dd: drop old workaround for lseek() bug in Linux kernel |
|
Date: |
Mon, 26 Oct 2020 14:55:46 +0100 |
On Monday, October 26, 2020 2:11:59 PM CET Pádraig Brady wrote:
> On 26/10/2020 10:44, Kamil Dudka wrote:
> > The workaround triggers warnings with new kernel versions in case
> > a user does not have sufficient privileges for the MTIOCGET ioctl.
> >
> > * src/dd.c (skip_via_lseek): Drop wrapper function no longer needed.
> > (skip): Use lseek() directly.
> > (advance_input_after_read_error): Use lseek() directly.
> >
> > Reported-by: Nir Soffer
> > Bug: https://bugzilla.redhat.com/1876840
>
> To clarify, the kernel is warning, not dd.
> In general the kernel should be disallowing rather than warning I think.
> But yes this is old code that should no longer be needed.
> I'll apply the patch.
>
> thanks,
> Pádraig
Perfect. Thank you for taking a quick action on this!
Kamil