[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33644: [PATCH] cp --preserve=xattr: preserve NFSv4 ACL extended attr
From: |
Kamil Dudka |
Subject: |
bug#33644: [PATCH] cp --preserve=xattr: preserve NFSv4 ACL extended attributes |
Date: |
Mon, 04 Mar 2019 10:38:27 +0100 |
On Sunday, March 3, 2019 3:07:53 AM CET Pádraig Brady wrote:
> So attr_copy_file() copies all except those defined in /etc/xattr.conf
... which is, however, not how xattr.conf is currently documented:
# /etc/xattr.conf
#
# Format:
# <pattern> <action>
#
# Actions:
# permissions - copy when trying to preserve permissions.
# skip - do not copy.
> ACL xattrs are listed in that file with the rationale from a comment in
> libattr being:
>
> "ACLs are excluded by default because copying them between
> file systems with and without ACL support needs some
> additional logic so that no unexpected permissions result."
>
> So the ACL handling specifically is deferred to libacl.
> Now system.posix_acl_access is handled by libacl,
> but system.nfs4_acl is not.
True.
> So I think the correct fix here is to remove the
> nfs entries from /etc/xattr.conf, and then cp will copy.
OK, I will propose it on the acl-devel mailing list, together with updating
the documentation of xattr.conf. We will see what attr/acl upstream thinks
about it.
> This has the advantage of being configurable,
> and also removes nfs4 specific handling from cp.
> Any nfs4 specific handling should be in libacl.
So you think it should. Nevertheless, in reality, libacl is not aware
of NFSv4 ACLs at all. And I am not aware of any plans to change this.
Kamil
> thanks,
> Pádraig