[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17668: [PATCH] build: be more specific about .git directory before e
|
From: |
Eric Blake |
|
Subject: |
bug#17668: [PATCH] build: be more specific about .git directory before enabling warnings |
|
Date: |
Mon, 02 Jun 2014 10:31:03 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/02/2014 02:54 AM, Ben Walton wrote:
> * configure.ac: When looking for a .git checkout, restrict it to git
> checkouts that contain a coreutils-specific tag.
>
> Signed-off-by: Ben Walton <address@hidden>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index a7a8bfc..96af9be 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -100,7 +100,7 @@ AC_ARG_ENABLE([gcc-warnings],
> # we're running from a git repo, then auto enable the warnings.
> gl_gcc_warnings=no
> gl_GCC_VERSION_IFELSE([4], [6],
> - [test -d "$srcdir"/.git && gl_gcc_warnings=yes])]
> + [test -f "$srcdir"/.git/refs/tags/v8.22 &&
> gl_gcc_warnings=yes])]
NACK. Git can compress tags to reside in other locations than
.git/refs/tags (run 'git gc --aggressive' for example). The idea of
testing for coreutils.git has merit, but you need to come up with a more
robust test.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature