[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14897: dd skip exit code
From: |
Pádraig Brady |
Subject: |
bug#14897: dd skip exit code |
Date: |
Thu, 18 Jul 2013 23:14:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 07/18/2013 10:43 PM, Bernhard Voelker wrote:
>
> On 07/18/2013 07:52 PM, Pádraig Brady wrote:
>
>> * NEWS: Mention the change in behavior
>
> s/$/./
>
>> @@ -2010,7 +2013,9 @@ dd_copy (void)
>>
>> if (nread < 0)
>> {
>> - error (0, errno, _("error reading %s"), quote (input_file));
>> + if (!(conversions_mask & C_NOERROR) || !(status_flags &
>> STATUS_NONE))
>> + error (0, errno, _("error reading %s"), quote (input_file));
>> +
>> if (conversions_mask & C_NOERROR)
>> {
>> print_stats ();
>
> This doesn't look like a non-fatal error to me. Are you sure
> we really want to suppress this with status=none?
I wasn't sure about that one since POSIX says you _shall_ output
a diagnostic in that case. But of course status=none is an extension,
so POSIX doesn't apply so. Also with conv=noerror this is just a warning,
so for consistency it seems right to treat like all other warnings.
> Reading the Texinfo manual, I think this change in behavior should
> also be documented:
>
> Do not print any informational messages to stderr. Error
> messages are output as normal.
>
> It probably should say something like "... any informational nor
> warning messages ...".
I will amend like that and push.
thanks for the review!
Pádraig.
- bug#14897: dd skip exit code, ffx, 2013/07/18
- bug#14897: dd skip exit code, Paul Eggert, 2013/07/18
- bug#14897: dd skip exit code, Pádraig Brady, 2013/07/18
- bug#14897: dd skip exit code, Paul Eggert, 2013/07/18
- bug#14897: dd skip exit code, Pádraig Brady, 2013/07/18
- bug#14897: dd skip exit code, Paul Eggert, 2013/07/18
- bug#14897: dd skip exit code, Bernhard Voelker, 2013/07/18
- bug#14897: dd skip exit code,
Pádraig Brady <=