[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] dd conv=unblock: print final newline consistently
From: |
Jim Meyering |
Subject: |
Re: [PATCH] dd conv=unblock: print final newline consistently |
Date: |
Thu, 10 Sep 2009 14:24:30 +0200 |
Eric Blake wrote:
> According to Jim Meyering on 9/10/2009 4:26 AM:
>> I don't like last-minute changes, but this seems safe, considering it's in
>> an obscure corner of dd. Who actually uses dd's conv=unblock option?
>> Of those precious few, who would notice the additional newline that
>> dd-with-this-patch now prints for most combinations of output size
>> and conversion block size?
>>
>> Comments welcome.
>>
>> BTW, this change makes GNU dd compatible with the vendor dd from at
>> least Solaris 10 and FreeBSD.
>
> Sounds like a good reason to me. And certainly more consistent with other
> tools (I always get annoyed when Solaris sed refuses to operate on
> trailing data that does not end in newline). I didn't see anything wrong
> with the patch.
Thanks for the review.
I've pushed that.
I'm expecting to release coreutils-7.6 tomorrow,
probably with the addition only of the documentation
(du,df etc --help) changes we're discussing.
Currently, we're at gnulib (v0.0-2549-g2c90f1a) for the submodule.
None of the patches since then seemed to be essential to coreutils
on non-mingw/cygwin systems. Let me know if you'd like to use
a newer version.