Re: [PATCH] dd: do not unnecesarilly allocate memory for input block size, when not needed

[Ondřej Vašík]

Pádraig Brady wrote:
> So that would not run skip(STDOUT_FILENO,...) if count==0.
> Would this break existing scripts that for example used
> this command to position a non seekable device?
> 
>   dd count=0 of=/dev/tape seek=1234

Thanks for objection, you are right, my patch seems to be not correct
way as it doesn't run that part and could break something. However - for
many cases (when file_size && offset < OFF_T_MAX and file seekable)
buffer allocation is not required in skip(), so it could be handled
somehow for those cases even without buffer allocation...

Greetings,
         Ondřej

signature.asc
Description: Toto je digitálně podepsaná část zprávy