Re: test failure in make check-root

[hggdh]

On Thu, 26 Mar 2009 20:50:51 +0100
Kamil Dudka <address@hidden> wrote:

> On Thursday 26 of March 2009 18:00:47 Jim Meyering wrote:
> > diff --git a/tests/install/install-C-root
> > b/tests/install/install-C-root index df2843d..d5cc2de 100755
> > --- a/tests/install/install-C-root
> > +++ b/tests/install/install-C-root
> > @@ -23,6 +23,7 @@ fi
> >
> >  . $srcdir/test-lib.sh
> >  require_root_
> > +"$abs_srcdir/setgid-check"  
> 
> . "$abs_srcdir/setgid-check"

$abs_scrdir/setgid-check does not have the eXecute bit on; patching as
Kamil indicated works:

address@hidden:/usr/src/buildd/coreutils/coreutils-git $ sudo make -C tests 
check TESTS=install/install-C-root
make: Entering directory `/usr/src/buildd/coreutils/coreutils-git/tests'
make  check-TESTS
make[1]: Entering directory `/usr/src/buildd/coreutils/coreutils-git/tests'
make[2]: Entering directory `/usr/src/buildd/coreutils/coreutils-git/tests'
./install/install-C-root: skipping test: this directory has the setgid bit set
SKIP: install/install-C-root.log

========================
 All 1 tests passed
 (1 tests were not run)
========================

make[2]: Leaving directory `/usr/src/buildd/coreutils/coreutils-git/tests'
make[1]: Leaving directory `/usr/src/buildd/coreutils/coreutils-git/tests'
make: Leaving directory `/usr/src/buildd/coreutils/coreutils-git/tests'
address@hidden:/usr/src/buildd/coreutils/coreutils-git $ 

After taking out the sgid bit:

address@hidden:/usr/src/buildd/coreutils/coreutils-git $ sudo make -C tests 
check TESTS=install/install-C-root
make: Entering directory `/usr/src/buildd/coreutils/coreutils-git/tests'
make  check-TESTS
make[1]: Entering directory `/usr/src/buildd/coreutils/coreutils-git/tests'
make[2]: Entering directory `/usr/src/buildd/coreutils/coreutils-git/tests'
PASS: install/install-C-root.log

====================
 All 1 tests passed
====================

make[2]: Leaving directory `/usr/src/buildd/coreutils/coreutils-git/tests'
make[1]: Leaving directory `/usr/src/buildd/coreutils/coreutils-git/tests'
make: Leaving directory `/usr/src/buildd/coreutils/coreutils-git/tests'
address@hidden:/usr/src/buildd/coreutils/coreutils-git $ 

..hggdh..

signature.asc
Description: PGP signature