bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] df: Fix bug when totaling unknown values.


From: Matthew Woehlke
Subject: Re: [PATCH] df: Fix bug when totaling unknown values.
Date: Wed, 25 Mar 2009 17:04:31 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.21) Gecko/20090320 Fedora/2.0.0.21-1.fc10 Thunderbird/2.0.0.21 Mnenhy/0.7.5.0

Paul Eggert wrote:
This fixes a bug reported by "make check" on a Solaris 10 host with
some funky file systems.

It was AIX ;-).

* src/df.c (show_dev): Don't add UINTMAX_MAX to grand totals, as that
value indicates that the true value is unknown; adding it effectively
subtracts 1 from the total, whereas we want to leave the total alone.

I thought the check needs to be against (unsigned)-2?

--
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
--
"Yoda of Borg am I. Futile is resistance. Assimilate you, I will."
  -- from http://en.wikipedia.org/wiki/Wikipedia:Yet_more_Best_of_BJAODN





reply via email to

[Prev in Thread] Current Thread [Next in Thread]