Re: [PATCH] ls: --color now highlights hard linked files, too

[Jim Meyering]

Kamil Dudka <address@hidden> wrote:
> Test moved to non-root tests, rediffed against current git HEAD.
>
> On Monday 20 October 2008 19:01:45 you wrote:
>> On Tuesday 14 October 2008 16:04:46 Jim Meyering wrote:
>> > I agree.  I'd rather add to (and remain consistent with) the existing
>> > framework than add a feature whereby the number of hard links is
>> > highlighted in long-style output.
>>
>> Proposed patch is attached.
>
> From e804b4ca6c9e89b668547797adbe1ea7b74e5dbf Mon Sep 17 00:00:00 2001
> From: Kamil Dudka <address@hidden>
> Date: Mon, 27 Oct 2008 15:38:23 +0100
> Subject: [PATCH] ls: --color now highlights hard linked files, too
>
> * src/ls.c (print_color_indicator): Colorize hard linked files.
> * src/dircolors.c: Add color for hard link.
> * src/dircolors.hin: Add color for hard link.
> * tests/ls/hardlink: Test for ls - colorize hard linked files.
> * tests/Makefile.am (TESTS): Add ls/hardlink.
> * NEWS: Mention the change.

Thanks!
Applied with this minor change:

diff --git a/tests/ls/hardlink b/tests/ls/hardlink
index 80405c1..d65bb7a 100755
--- a/tests/ls/hardlink
+++ b/tests/ls/hardlink
@@ -22,9 +22,7 @@ if test "$VERBOSE" = yes; then
 fi

 . $srcdir/test-lib.sh
-
-# Don't let a different umask perturb the results.
-umask 22
+working_umask_or_skip_

 touch file file1 || framework_failure
 ln file1 file2 || skip_test_ "can't create hard link"