Re: seq: revert Solaris 8 work-around that caused x86 regression

[Jim Meyering]

Paul Eggert <address@hidden> wrote:
> Here's the bug:
>
> $ seq 9223372036854775807 9223372036854775808
> 9223372036854775807
> 9223372036854775808
> 9223372036854775809
...
> We can't easily add the above test case, since it's not portable to
> hosts where long double == double.

Here's a proposed patch.
Do any of you know of a system on which it would fail?

>From cb6a11e3a314a81904c893df21828cd0d1d356dc Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 25 Oct 2008 11:34:14 +0200
Subject: [PATCH] tests: seq: check for today's extended long double fix

* tests/misc/seq-long-double: New file.  Test for today's bug fix.
* tests/check.mk (TESTS_ENVIRONMENT): Export CC definition.
* tests/Makefile.am (TESTS): Add misc/seq-long-double.
* NEWS (Bug fixes): Mention it.
---
 NEWS                       |    6 ++++++
 tests/Makefile.am          |    1 +
 tests/check.mk             |    1 +
 tests/misc/seq-long-double |   37 +++++++++++++++++++++++++++++++++++++
 4 files changed, 45 insertions(+), 0 deletions(-)
 create mode 100755 tests/misc/seq-long-double

diff --git a/NEWS b/NEWS
index 357efc2..83d0165 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,12 @@ GNU coreutils NEWS                                    -*- 
outline -*-

   stat -f recognizes the Lustre file system type

+** Bug fixes
+
+  seq 9223372036854775807 9223372036854775808 now prints only two numbers
+  on systems with extended long double support, like x86
+  [bug introduced in coreutils-6.11]
+
 ** Changes in behavior

   ls -l now marks SELinux-only files with the less obtrusive '.',
diff --git a/tests/Makefile.am b/tests/Makefile.am
index d73ce32..808c61e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -124,6 +124,7 @@ TESTS =                                             \
   misc/ptx                                     \
   misc/test                                    \
   misc/seq                                     \
+  misc/seq-long-double                                 \
   misc/head                                    \
   misc/head-elide-tail                         \
   tail-2/tail-n0f                              \
diff --git a/tests/check.mk b/tests/check.mk
index 0361d0c..527e505 100644
--- a/tests/check.mk
+++ b/tests/check.mk
@@ -80,6 +80,7 @@ TESTS_ENVIRONMENT =                           \
   top_srcdir='$(top_srcdir)'                   \
   CONFIG_HEADER='$(abs_top_builddir)/lib/config.h' \
   CU_TEST_NAME=`basename '$(abs_srcdir)'`,$$tst        \
+  CC='$(CC)'                                   \
   AWK='$(AWK)'                                 \
   EGREP='$(EGREP)'                             \
   EXEEXT='$(EXEEXT)'                           \
diff --git a/tests/misc/seq-long-double b/tests/misc/seq-long-double
new file mode 100755
index 0000000..a792ab0
--- /dev/null
+++ b/tests/misc/seq-long-double
@@ -0,0 +1,37 @@
+#!/bin/sh
+# FIXME
+
+# Copyright (C) 2008 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+if test "$VERBOSE" = yes; then
+  set -x
+  seq --version
+fi
+
+. $srcdir/test-lib.sh
+
+echo 'int foo[sizeof (long double) - sizeof (double) - 1];' > long.c
+$CC -c long.c || skip_test_ 'long double == double'
+
+a=9223372036854775807
+b=$(echo $a|sed 's/7$/8/')
+
+fail=0
+seq $a $b > out || fail=1
+printf "$a\n$b\n" > exp || fail=1
+compare out exp || fail=1
+
+Exit $fail
--
1.6.0.3.517.g759a