[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH x 5] warnings, some legit
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH x 5] warnings, some legit |
|
Date: |
Thu, 16 Oct 2008 22:29:22 +0200 |
Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>
>> +#define TMP (char *) "/tmp"
>> ...
>
> How about the following change to mktemp.c instead? It's simpler, and
> avoids the need for the macro and the cast.
>
> 2008-10-16 Paul Eggert <address@hidden>
>
> * src/mktemp.c (main): Add 'const' twice to avoid GCC warning.
Ahh... much better. no-casts is always better.
Thanks!
I've just pushed that.
- [PATCH x 5] warnings, some legit, Jim Meyering, 2008/10/15
- Re: [PATCH x 5] warnings, some legit, Eric Blake, 2008/10/15
- Re: [PATCH x 5] warnings, some legit, Paul Eggert, 2008/10/16
- Re: [PATCH x 5] warnings, some legit,
Jim Meyering <=
- Re: [PATCH x 5] warnings, some legit, Jim Meyering, 2008/10/16