[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: Fix for several getdate.y issues
From: |
Jim Meyering |
Subject: |
Re: [PATCH]: Fix for several getdate.y issues |
Date: |
Tue, 01 Jul 2008 18:12:01 +0200 |
Ondřej Vašík <address@hidden> wrote:
> Jim Meyering wrote:
...
> From 4c9db16207b5c76bb85b05ee5853c525372bb80a Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <address@hidden>
> Date: Fri, 27 Jun 2008 16:32:28 +0200
> Subject: [PATCH] *lib/getdate.y: Do not ignore specified time zone when
> relative offset for days/months/years is specified.
>
> Signed-off-by: Ondřej Vašík <address@hidden>
> ---
> lib/getdate.y | 40 ++++++++++++++++++++--------------------
> 1 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/lib/getdate.y b/lib/getdate.y
> index 1deec51..7b55c31 100644
> --- a/lib/getdate.y
> +++ b/lib/getdate.y
> @@ -1436,26 +1436,7 @@ get_date (struct timespec *result, char const *p,
> struct timespec const *now)
...
> - /* Add relative date. */
> + /* Add relative date. */
That indentation-only change appears to be unnecessary.
It looks like your factorization change (#2) can be applied first,
and if so, I'll apply it shortly.
For the remainder, when you resend with unit-test additions,
please post them one per message.
Also, do consider whether any of these changes merit
changes to the documentation in doc/getdate.texi.