bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] truncate: Ignore whitespace in --size parameters


From: Jim Meyering
Subject: Re: [PATCH] truncate: Ignore whitespace in --size parameters
Date: Mon, 30 Jun 2008 12:20:32 +0200

Pádraig Brady <address@hidden> wrote:
...
>> diff --git a/tests/misc/truncate-parameters b/tests/misc/truncate-parameters
>> Subject: [PATCH] truncate: ignore whitespace in --size parameters
>>
>> Without this, `truncate -s '> -1' F` would truncate F to length 0,
>> and `truncate -s " +1" F` would truncate F to 1 byte.  Now, each
>> elicits a diagnostic.
>
> Actually the latter is allowed, but will now do the right thing.

Oh!  Sorry about that.  Thanks for pointing it out.

This is the sort of mistake that will probably make me 1) start
pushing initially to a "next"-style branch (hoping to catch mistakes
before pushing to a read-only "master") or 2) reinstate use of a
version-controlled ChangeLog file.

A third alternative (perhaps in addition to #1):
  adjust the gitlog-to-changelog script to make selected, scripted
  corrections, fixing errors like this, so that the generated
  ChangeLog will be correct.  I'm maintaining a list of these.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]