bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

recent const churn


From: Eric Blake
Subject: recent const churn
Date: Mon, 16 Jun 2008 15:44:20 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

After the recent churn in const-qualification in coreutils.git, there are still 
a couple of redundant qualifiers, as found by:

$ git grep '\bconst\b[^*]*\bconst\b' -- '*.[ch]'
src/ls.c:static const char const *long_time_format[2] =
src/ls.c:static const qsortFunc const sort_functions[][2][2][2] =
src/od.c:static const char const charname[33][4] =

Sounds like an updated maintainer rule to check for redundant const might be 
useful?  Or, if you like enforcing your HACKING rule of 'type const' 
over 'const type', would adding a syntax-check rule to look for 'static const' 
be useful?

-- 
Eric Blake







reply via email to

[Prev in Thread] Current Thread [Next in Thread]