Re: FYI, help2man change required for perl 5.10

[Jim Meyering]

Jim Meyering <address@hidden> wrote:

>>From 58525a9ce493cb71fde6f74e036d627c9c65bec0 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Mon, 5 May 2008 22:44:57 +0200
> Subject: [PATCH] help2man: avoid failure with perl 5.10

That wasn't quite right.
While it worked on Debian unstable, it failed on rawhide.
This additional change makes it work on both:

>From 2224ef83fe7c82b2643a62bc7f98a2f589660ce8 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 6 May 2008 00:35:28 +0200
Subject: [PATCH] help2man: fix perl 5.10 problem properly

* man/help2man: Do pull LC_ALL via "use POSIX".
Instead, limit the importing of gettext-related symbols
to just those two we'll use: gettext and textdomain.

Signed-off-by: Jim Meyering <address@hidden>
---
 man/help2man |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/man/help2man b/man/help2man
index 652fe9c..f000735 100755
--- a/man/help2man
+++ b/man/help2man
@@ -24,7 +24,7 @@ use 5.005;
 use strict;
 use Getopt::Long;
 use Text::Tabs qw(expand);
-use POSIX qw(strftime setlocale);
+use POSIX qw(strftime setlocale LC_ALL);
 use locale;

 my $this_program = 'help2man';
@@ -34,7 +34,7 @@ my $have_gettext;
 BEGIN {
     eval {
        require Locale::gettext;
-       Locale::gettext->import;
+       Locale::gettext->import (qw(gettext textdomain));
        $have_gettext = 1;
     };

--
1.5.5.1.126.g02179