Re: [PATCH] Implement join --check-order and --nocheck-order.

[Jim Meyering]

"Dmitry V. Levin" <address@hidden> wrote:
> On Tue, Feb 19, 2008 at 03:44:00PM +0100, Jim Meyering wrote:
>> James Youngman <address@hidden> wrote:
>> > This is a consolidated patch including all the previous changes,
>> > implementing order checking in join by default.  "make distcheck"
>> > works (if I move distcheck-hook from Makefile.am to GNUmakefile).
>> >
>> > 2008-02-16  James Youngman  <address@hidden>
>> >
>> >    * src/join.c: Support --check-order and --nocheck-order.
>> >    New variables check_input_order, seen_unpairable and
>> >    issued_disorder_warning[]. For --check-order, verify that the
>> ...
>>
>> Thanks again.
>> I've just pushed that.
>
> Looks like this commit v6.10-70-ga1e7156 introduces a regression:
>
> $ printf '%s\n%s\n' '1 b' '2 a' | sort -k2,2 | join -12 -21 - /dev/null
> join: File 1 is not in sorted order
> $ echo $?
> 1
> $ join --version |grep join
> join (GNU coreutils) 6.10.133-677610

Thanks again.
I've pushed the patch:

    join bug fix: adapt keycmp to work with new order-checking feature

    * src/join.c (keycmp): Add two join-field parameters.
    (check_order, join): Update callers.
    Reported by Dmitry V. Levin in
    http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/12731/focus=13017
    * tests/join/Test.pm (chkodr-7): New test for this fix.