[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: sha512_process_bytes doesn't like odd sized buffers
|
From: |
Andreas Schwab |
|
Subject: |
Re: sha512_process_bytes doesn't like odd sized buffers |
|
Date: |
Sat, 15 Mar 2008 15:36:57 +0100 |
|
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) |
Jim Meyering <address@hidden> writes:
> The bug strikes whenever ctx->buflen|64 != 0.
Btw, ctx->buflen|64 != 0 is always true because it is the same as
ctx->buflen|(64 != 0).
> - sha256_process_block (ctx->buffer, ctx->buflen & ~63, ctx);
> -
> ctx->buflen &= 63;
> + sha256_process_block (ctx->buffer, ctx->buflen, ctx);
I hope you are aware of that a & 63 is different from a & ~63?
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."