Re: [PATCH] split: --verbose output to stdout

[Jim Meyering]

Steven Schubiger <address@hidden> wrote:
> diff --git a/src/split.c b/src/split.c
> index 5807a1c..2ad0baf 100644
> --- a/src/split.c
> +++ b/src/split.c
> @@ -208,7 +208,7 @@ cwrite (bool new_file_flag, const char *bp, size_t bytes)
>
>        next_file_name ();
>        if (verbose)
> -     fprintf (stderr, _("creating file %s\n"), quote (outfile));
> +     fprintf (stdout, _("creating file %s\n"), quote (outfile));
>        output_desc = open (outfile,
>                         O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
>                         (S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP

That's probably ok. i.e., it's probably ok not to call fflush there.

You'll want to adjust the help output, too:

    $ split --help|grep verb
          --verbose           print a diagnostic to standard error just

Please check the texinfo documentation, too.
It'd be nice if you were to include a ChangeLog entry.

No rush of course, since I won't apply such a change until
after the upcoming stable release.  In fact, why don't you
do both split and mkdir at the same time, and then you can
simply remove that item from TODO as part of the patch.

Finally, please run "make check" or even "make distcheck"
to make sure all tests pass with your changes.