[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] df: print negative value correctly
From: |
Li Zefan |
Subject: |
Re: [PATCH 1/2] df: print negative value correctly |
Date: |
Thu, 29 Nov 2007 16:14:29 +0800 |
User-agent: |
Thunderbird 2.0.0.0 (X11/20070419) |
Paul Eggert wrote:
> Li Zefan <address@hidden> writes:
>
>> Function df_readable() won't print negative value correctly. Don't pass -n
>> to human_readable(), add a prefix '-' in the char buffer is enough.
>
> I don't see why this change is needed. Can you give an example?
> For example, this code in show_dev:
>
> used = total - available_to_root;
> negate_used = (total < available_to_root);
>
> suggests that -n should be passed.
>
>
Hmmm, I have to admit I made a mistake. Please ignore this patch, and I'll
revise the second patch.