[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Command line parsing of ls with genparse
From: |
Michael Geng |
Subject: |
Re: [PATCH] Command line parsing of ls with genparse |
Date: |
Thu, 30 Aug 2007 18:50:02 +0200 |
User-agent: |
Mutt/1.5.9i |
On Wed, Aug 29, 2007 at 11:39:46PM +0200, Jim Meyering wrote:
> address@hidden (Michael Geng) wrote:
> ...
> > of text. In the present version of ls the usage() function calls
> > fputs() several times. The genparse version prints everything in
> > 1 single call to printf(). So the usage() text in the present ls.c
> > is split into multiple _() macros, whereas ls-clp.c uses 1 single _()
> > macro for the whole help screen.
>
> Consider separating it into strings no longer than 509 bytes each
> and printing them separately. That's a portability limitation imposed
> by some c89 compilers. (see gcc's -Woverlength-strings)
>
> If you were to run "make distcheck", this and some other problems
> would be exposed. For example, you added at least one function
> that was not declared static.
>
> With your changes does "make check" still pass?
Yes, I verified that that it passes "make check". "make distcheck"
is new to me however, I haven't yet tried that.
Michael
- Re: [PATCH] Command line parsing of ls with genparse, (continued)
- Re: [PATCH] Command line parsing of ls with genparse, Eric Blake-1, 2007/08/28
- Re: [PATCH] Command line parsing of ls with genparse, John Cowan, 2007/08/28
- Re: [PATCH] Command line parsing of ls with genparse, Jim Meyering, 2007/08/28
- Re: [PATCH] Command line parsing of ls with genparse, Michael Geng, 2007/08/29
- Re: [PATCH] Command line parsing of ls with genparse, Michael Geng, 2007/08/29
- Re: [PATCH] Command line parsing of ls with genparse, Eric Blake, 2007/08/29