bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: portability tweak for Tru64 V4.0.


From: Paul Eggert
Subject: Re: FYI: portability tweak for Tru64 V4.0.
Date: Wed, 25 Oct 2006 11:42:47 -0700
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)

Jim Meyering <address@hidden> writes:

> +static inline off_t ftello (FILE *stream)
> +{
> +  off_t off = ftell (stream);
> +  if (off < 0)
> +    return off;
> +  if (off != (long int) off)
> +    {
> +      errno = EOVERFLOW;
> +      return -1;
> +    }
> +  return off;
> +}

Something's odd here.  ftell returns long int, so the ftello
substitute needs to worry about overflow only on hosts where long int
is wider than off_t.  But I don't know of any such hosts and don't
expect that there will ever be any.  Surely on Tru64 both types are
64-bit.

How about this alternative instead?

static inline off_t
ftello (FILE *stream)
{
  return ftell (stream);
}




reply via email to

[Prev in Thread] Current Thread [Next in Thread]