bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: root-dev-ino.c limitation


From: Jim Meyering
Subject: Re: root-dev-ino.c limitation
Date: Fri, 03 Mar 2006 17:53:00 +0100

address@hidden (Eric Blake) wrote:
...
> I've already done a first cut at the edits, attached for review.
> Obviously, I will need to clean up where
> DOUBLE_SLASH_IS_DISTINCT_ROOT gets defined, and merge
> this patch in with my outstanding basename/dirname patch
> before it can be applied.  But it was surprisingly easier than
> I feared, and also uncovered a real bug in pwd.c (file_name_prepend
> already adds /, so when your current directory is "/", pwd
> was printing "//").

Thanks, this does look good.
Would you please keep the bug-fix separate, and include
a test for it, if possible?

Why do you want to merge this change with the
already-big basename/dirname one?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]